Change in ...coreboot[master]: nb/sandybridge/raminit_common.c: Remove variable set but not used

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]: SMBIOS...

HAOUAS Elyes (Code Review)

25 May 2019 25 May '19

11:34 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33005

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

nb/sandybridge/raminit_common.c: Remove variable set but not used

Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 9 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/33005/1

diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 5347c5c..b8ad3c0 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -1824,7 +1824,7 @@

static void adjust_high_timB(ramctr_timing * ctrl) { - int channel, slotrank, lane, old; + int channel, slotrank, lane; MCHBAR32(0x3400) = 0x200; FOR_ALL_POPULATED_CHANNELS { fill_pattern1(ctrl, channel); @@ -1898,15 +1898,18 @@ 0x100 * channel + 4); res |= ((u64) MCHBAR32(lane_registers[lane] + 0x100 * channel + 8)) << 32; - old = ctrl->timings[channel][slotrank].lanes[lane].timB; - ctrl->timings[channel][slotrank].lanes[lane].timB += - get_timB_high_adjust(res) * 64;

printram("High adjust %d:%016llx\n", lane, res); - printram("Bval+: %d, %d, %d, %x -> %x\n", channel, - slotrank, lane, old, + printram("Bval+: %d, %d, %d, %x", channel, + slotrank, lane, ctrl->timings[channel][slotrank].lanes[lane]. timB); + ctrl->timings[channel][slotrank].lanes[lane].timB += + get_timB_high_adjust(res) * 64; + printram(" -> %x\n", + ctrl->timings[channel][slotrank].lanes[lane]. + timB); + } } MCHBAR32(0x3400) = 0;

Attachments:

attachment.htm (text/html — 4.1 KB)

Show replies by date

build bot (Jenkins) (Code Review)

25 May 25 May

11:34 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33005 )

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33005/1/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/33005/1/src/northbridge/intel/sandybridge/ra... PS1, Line 1906: timB); Avoid multiple line dereference - prefer 'ctrl->timings[channel][slotrank].lanes[lane].timB'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Gerrit-Change-Number: 33005 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 25 May 2019 09:34:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

11:57 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33005 )

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33005/2/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/33005/2/src/northbridge/intel/sandybridge/ra... PS2, Line 1906: timB); Avoid multiple line dereference - prefer 'ctrl->timings[channel][slotrank].lanes[lane].timB'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Gerrit-Change-Number: 33005 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 25 May 2019 09:57:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

12:41 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33005 )

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/33005/3/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/33005/3/src/northbridge/intel/sandybridge/ra... PS3, Line 1906: timB); Avoid multiple line dereference - prefer 'ctrl->timings[channel][slotrank].lanes[lane].timB'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Gerrit-Change-Number: 33005 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sat, 25 May 2019 10:41:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

29 May 29 May

7:29 a.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33005 )

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/33005/4/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/33005/4/src/northbridge/intel/sandybridge/ra... PS4, Line 1905: timB); Avoid multiple line dereference - prefer 'ctrl->timings[channel][slotrank].lanes[lane].timB'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Gerrit-Change-Number: 33005 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 29 May 2019 05:29:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

6 Jun 6 Jun

4:18 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33005 )

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/#/c/33005/5/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/33005/5/src/northbridge/intel/sandybridge/ra... PS5, Line 1934: timB); Avoid multiple line dereference - prefer 'ctrl->timings[channel][slotrank].lanes[lane].timB'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Gerrit-Change-Number: 33005 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Jun 2019 14:18:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

9:16 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33005 )

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/#/c/33005/6/src/northbridge/intel/sandybridge/ra... File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/#/c/33005/6/src/northbridge/intel/sandybridge/ra... PS6, Line 1934: timB); Avoid multiple line dereference - prefer 'ctrl->timings[channel][slotrank].lanes[lane].timB'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Gerrit-Change-Number: 33005 Gerrit-PatchSet: 6 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 06 Jun 2019 19:16:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

build bot (Jenkins) (Code Review)

6 Sep 6 Sep

10:43 a.m.

New subject: Change in coreboot[master]: nb/sandybridge/raminit_common.c: Remove variable set but not used

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33005 )

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

Patch Set 7:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33005/7/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:

https://review.coreboot.org/c/coreboot/+/33005/7/src/northbridge/intel/sandy... PS7, Line 1934: timB); Avoid multiple line dereference - prefer 'ctrl->timings[channel][slotrank].lanes[lane].timB'

-- To view, visit https://review.coreboot.org/c/coreboot/+/33005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Gerrit-Change-Number: 33005 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Fri, 06 Sep 2019 08:43:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

13 Dec 13 Dec

5:43 p.m.

New subject: Change in coreboot[master]: nb/sandybridge/raminit_common.c: Remove variable set but not used

HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33005 )

Change subject: nb/sandybridge/raminit_common.c: Remove variable set but not used ......................................................................

Abandoned

-- To view, visit https://review.coreboot.org/c/coreboot/+/33005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I109353775fe4ecce6a05ef88781939243f398d17 Gerrit-Change-Number: 33005 Gerrit-PatchSet: 7 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: abandon

1607

days inactive

1809

days old

coreboot-gerrit@coreboot.org

8 comments

2 participants

tags (0)

participants (2)

build bot (Jenkins) (Code Review)
HAOUAS Elyes (Code Review)