Attention is currently required from: Martin Roth, Henry Sun, Tao Xia.
zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51380 )
Change subject: mb/google/dedede/var/blipper: Add camera support
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/variants/blipper/gpio.c:
https://review.coreboot.org/c/coreboot/+/51380/comment/5ada33c0_690bce05
PS1, Line 10: /* D13 : EN_PP2800_CAMERA */
: PAD_CFG_GPO(GPP_D13, 1, PLTRST),
Where is this GPIO used. I dont see it exported in the ACPI table.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51380
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I806ec207a454d4383aca093159553b7e618e16b2
Gerrit-Change-Number: 51380
Gerrit-PatchSet: 2
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Sat, 13 Mar 2021 07:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment