Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/41343 )
Change subject: haswell: Make VGA on FDI work ......................................................................
Patch Set 10:
(8 comments)
https://review.coreboot.org/c/libgfxinit/+/41343/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/libgfxinit/+/41343/8//COMMIT_MSG@26 PS8, Line 26: However, this was not : the case, because one of the link ends programmed the link width for DP : unconditionally, so one end of FDI would always end up using x1 width. :
Sounds good.
Done (reworded a bit so that it fits in 72 chars, and fixed a typo)
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... File common/haswell/hw-gfx-gma-pch-lynxpoint.adb:
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... PS8, Line 2: -- Copyright (C) 2015-2016 secunet Security Networks AG
Because I copied the file from elsewhere and didn't change the copyright notice. […]
Done
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... PS8, Line 38: 100
Oh, it's milliseconds. Sounds good.
Done
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... PS8, Line 57: Mask_Set => 16#12# * 2 ** 24);
Hrm, maybe it's a good idea.
I did something, let me know what you think
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... PS8, Line 158: end Unbend_Clkout_Dp;
Will add a disable procedure
Done
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... File common/haswell/hw-gfx-gma-pch-lynxpoint.ads:
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... PS8, Line 2: -- Copyright (C) 2015-2016 secunet Security Networks AG
Same as body
Done
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... PS8, Line 18: procedure Enable_Clkout_Dp;
The thing is that FDI mPHY config happens in between. […]
Done
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... File common/haswell/hw-gfx-gma-power_and_clocks_haswell.adb:
https://review.coreboot.org/c/libgfxinit/+/41343/8/common/haswell/hw-gfx-gma... PS8, Line 296: PCH.Lynxpoint.Unbend_Clkout_Dp;
This is something that isn't needed after reset, right? […]
Done