Attention is currently required from: John Su, Martin Roth, Paul Menzel, Chris Wang, chris wang.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49683 )
Change subject: mb/google/zork/var/vilboz: Add Mainboard Type for VCORE IC
......................................................................
Patch Set 11: Code-Review+2
(1 comment)
File src/mainboard/google/zork/variants/vilboz/romstage.c:
https://review.coreboot.org/c/coreboot/+/49683/comment/0207ba24_54249649
PS11, Line 5: #include <console/uart.h>
nits: this not need.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49683
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If153c0a3e641ae32ef89737925bd9f62dfb71f3d
Gerrit-Change-Number: 49683
Gerrit-PatchSet: 11
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: chris wang
Chris.Wang@amd.com
Gerrit-Attention: John Su
john_su@compal.corp-partner.google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Thu, 04 Mar 2021 13:06:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment