HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43341 )
Change subject: src/drivers/usb/ehci_debug.c: Add missing include ......................................................................
src/drivers/usb/ehci_debug.c: Add missing include
Replace unused <stddef.h> by missing <stdint.h>. This needed for 'u64'.
Change-Id: Ie99c27bd6a7d982bba9a93342f3e3b83a1c09e8d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/usb/ehci_debug.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43341/1
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index 5af8e2e..8641b13 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> +#include <stdint.h> #include <console/console.h> #include <console/usb.h> #include <arch/io.h>
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43341 )
Change subject: src/drivers/usb/ehci_debug.c: Add missing include ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/43341/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43341/1//COMMIT_MSG@9 PS1, Line 9: This needed "This is needed" or "Needed"
https://review.coreboot.org/c/coreboot/+/43341/1//COMMIT_MSG@9 PS1, Line 9: by with
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43341 )
Change subject: src/drivers/usb/ehci_debug.c: Add missing include ......................................................................
Patch Set 1: Code-Review+2
Hello build bot (Jenkins), Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43341
to look at the new patch set (#2).
Change subject: src/drivers/usb/ehci_debug.c: Add missing include ......................................................................
src/drivers/usb/ehci_debug.c: Add missing include
Replace unused <stddef.h> with missing <stdint.h>. This is needed for 'u64'.
Change-Id: Ie99c27bd6a7d982bba9a93342f3e3b83a1c09e8d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/usb/ehci_debug.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/41/43341/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43341 )
Change subject: src/drivers/usb/ehci_debug.c: Add missing include ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43341/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43341/1//COMMIT_MSG@9 PS1, Line 9: by
with
Done
https://review.coreboot.org/c/coreboot/+/43341/1//COMMIT_MSG@9 PS1, Line 9: This needed
"This is needed" or "Needed"
Thx
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43341 )
Change subject: src/drivers/usb/ehci_debug.c: Add missing include ......................................................................
src/drivers/usb/ehci_debug.c: Add missing include
Replace unused <stddef.h> with missing <stdint.h>. This is needed for 'u64'.
Change-Id: Ie99c27bd6a7d982bba9a93342f3e3b83a1c09e8d Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/43341 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/usb/ehci_debug.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/usb/ehci_debug.c b/src/drivers/usb/ehci_debug.c index e5841d7..07d87ae 100644 --- a/src/drivers/usb/ehci_debug.c +++ b/src/drivers/usb/ehci_debug.c @@ -1,6 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
-#include <stddef.h> +#include <stdint.h> #include <console/console.h> #include <console/usb.h> #include <arch/io.h>