Attention is currently required from: V sujith kumar Reddy, Raul Rangel, Ian Feng, Chris Wang, Karthik Ramasubramanian.
reddysujith has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63779 )
Change subject: mb/google/skyrim/var/skyrim: Add audio codec and amp support
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/skyrim/variants/skyrim/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/63779/comment/c82cfc38_5a3d5705
PS4, Line 174: ACPI_GPIO_IRQ_LEVEL_LOW
I use fw_config to differentiate the two audio codec setting. […]
This is codec requirement on states( LEVEL_LOW and EDGE_BOTH).
we can check this in the below links
https://elixir.bootlin.com/linux/latest/source/sound/soc/codecs/rt5682s.c#L3...
https://elixir.bootlin.com/linux/latest/source/sound/soc/codecs/nau8825.c#L2...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63779
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36d7b5c4e88825ceaa6922d9e3bed366f55a0d81
Gerrit-Change-Number: 63779
Gerrit-PatchSet: 4
Gerrit-Owner: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: V sujith kumar Reddy
vsujithkumar.reddy@amd.corp-partner.google.com
Gerrit-Reviewer: Yu-hsuan Hsu
yuhsuan@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Amanda Hwang
amanda_hwang@compal.corp-partner.google.com
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Van Chen
van_chen@compal.corp-partner.google.com
Gerrit-CC: reddysujith
Gerrit-Attention: V sujith kumar Reddy
vsujithkumar.reddy@amd.corp-partner.google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 12:54:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-MessageType: comment