Attention is currently required from: Ivy Jian, Kapil Porwal, Paul Menzel, Tarun Tuli.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75607?usp=email )
Change subject: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75607/comment/f3be2792_3e6bcb0f :
PS1, Line 7: mb/{google,intel}: Choose correct SoC type between MTL-U/P and MTL-S
I’d make it two commits: […]
Acknowledged
https://review.coreboot.org/c/coreboot/+/75607/comment/0ec79c7d_b1ffddf1 :
PS1, Line 9: This patch ensures that mainboards built with Intel Meteor Lake SoC
: are able to specify the correct SoC type between MTL-U/P and MTL-S.
:
: It will help to override the FSP UPD parameters properly.
Looking at the diff, that’s too broad? Maybe (for each board): […]
Acknowledged
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75607?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b1dec47ef9d12ac50317b86c4f0bc5fbe4e4dc3
Gerrit-Change-Number: 75607
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Comment-Date: Fri, 02 Jun 2023 15:30:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment