Attention is currently required from: Hung-Te Lin, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51174 )
Change subject: soc/mediatek/mt8192: Increase PRERAM_CBMEM_CONSOLE to 128K
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51174/comment/6ceef39a_b4ed9c39
PS1, Line 9: 128K
What is the current default?
Done
File src/soc/mediatek/mt8192/include/soc/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/51174/comment/75e157f4_079aa5a2
PS1, Line 51: 128K
Do you mean config CONSOLE_CBMEM_BUFFER_SIZE ? We can definitely increase that as well.
Yes. However, even if we increase it to >=430K, there's still no enough space for PRERAM_CBMEM_CONSOLE to store the whole full-k log. Therefore it seems there's no need to increase CONSOLE_CBMEM_BUFFER_SIZE.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51174
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I896884d298e197149f75865e9d00579124a34404
Gerrit-Change-Number: 51174
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 04 Mar 2021 00:42:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment