Change in ...coreboot[master]: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Subrata Banik (Code Review)

11 May 2019 11 May '19

4:43 p.m.

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32751

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable

Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/rules.h 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/32751/1

diff --git a/src/include/rules.h b/src/include/rules.h index 801a7fe..5ee535b 100644 --- a/src/include/rules.h +++ b/src/include/rules.h @@ -257,9 +257,14 @@

#endif

+#if CONFIG(RAMPAYLOAD) +/* ENV_PAYLOAD_LOADER is set to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable */ +#define ENV_PAYLOAD_LOADER ENV_POSTCAR +#else /* ENV_PAYLOAD_LOADER is set when you are in a stage that loads the payload. * For now, that is the ramstage. */ #define ENV_PAYLOAD_LOADER ENV_RAMSTAGE +#endif

/** * For pre-DRAM stages and post-CAR always build with simple device model, ie.

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Subrata Banik (Code Review)

14 May 14 May

5:52 p.m.

Hello Aaron Durbin, ron minnich, build bot (Jenkins), Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32751

to look at the new patch set (#6).

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable

Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/rules.h 1 file changed, 7 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/32751/6

Subrata Banik (Code Review)

15 May 15 May

4:59 p.m.

Subrata Banik has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Abandoned

parking for now, let see if we need this later

Subrata Banik (Code Review)

25 May 25 May

1:40 a.m.

Subrata Banik has restored this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Restored

Subrata Banik (Code Review)

1:41 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Patch Set 6:

HI Ron,

can you please help me to get this issue fixed. I'm unable to understand the dependency part in AMD library

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Fri, 24 May 2019 23:41:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

1:41 a.m.

Subrata Banik has removed Furquan Shaikh from this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Removed reviewer Furquan Shaikh.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 6 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-MessageType: deleteReviewer

Subrata Banik (Code Review)

2:13 a.m.

Hello Aaron Durbin, Furquan Shaikh, ron minnich, build bot (Jenkins), Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32751

to look at the new patch set (#7).

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable

Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/rules.h 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/32751/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

2:22 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Patch Set 7:

...

Patch Set 6:

HI Ron,

can you please help me to get this issue fixed. I'm unable to understand the dependency part in AMD library

here is build failure: https://qa.coreboot.org/job/coreboot-gerrit/94821/testReport/junit/(root)/bo...

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Sat, 25 May 2019 00:22:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

ron minnich (Code Review)

30 May 30 May

1:27 a.m.

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Patch Set 7:

diff --git a/src/vendorcode/amd/pi/Makefile.inc b/src/vendorcode/amd/pi/Makefile.inc index 4c8db6ab50..4e8787bed2 100644 --- a/src/vendorcode/amd/pi/Makefile.inc +++ b/src/vendorcode/amd/pi/Makefile.inc @@ -100,8 +100,8 @@ $(call src-to-obj,libagesa,$1): $(agesa_src_path)/$(notdir $1) $(obj)/config.h $ @printf " CC $$(subst $(obj)/,,$$(@))\n" $(CC_libagesa) -c -MMD $(CFLAGS_libagesa) $(AGESA_CFLAGS) \ $(AGESA_INC) \ - -include $(src)/include/rules.h \ -include $(src)/include/kconfig.h \ + -include $(src)/include/rules.h \ -include $(src)/commonlib/include/commonlib/compiler.h \ -o $$@ \ $(agesa_src_path)/$(notdir $1)

fixes it.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 7 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Wed, 29 May 2019 23:27:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

6:54 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Patch Set 8:

...

Patch Set 7:

diff --git a/src/vendorcode/amd/pi/Makefile.inc b/src/vendorcode/amd/pi/Makefile.inc index 4c8db6ab50..4e8787bed2 100644 --- a/src/vendorcode/amd/pi/Makefile.inc +++ b/src/vendorcode/amd/pi/Makefile.inc @@ -100,8 +100,8 @@ $(call src-to-obj,libagesa,$1): $(agesa_src_path)/$(notdir $1) $(obj)/config.h $ @printf " CC $$(subst $(obj)/,,$$(@))\n" $(CC_libagesa) -c -MMD $(CFLAGS_libagesa) $(AGESA_CFLAGS) \ $(AGESA_INC) \
                 -include $(src)/include/rules.h                            \
                 -include $(src)/include/kconfig.h                          \
                 -include $(src)/include/rules.h                            \
                 -include $(src)/commonlib/include/commonlib/compiler.h     \
                 -o $$@                                                     \
                 $(agesa_src_path)/$(notdir $1)
fixes it.

Thanks a lot Ron

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Thu, 30 May 2019 04:54:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

ron minnich (Code Review)

6:05 p.m.

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Patch Set 8:

This is weird. Why am I not seeing the changed amd/pi/Makefile.inc here? did it change upstream?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-Comment-Date: Thu, 30 May 2019 16:05:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Kyösti Mälkki (Code Review)

6:45 p.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Patch Set 8:

...

Patch Set 8:

This is weird. Why am I not seeing the changed amd/pi/Makefile.inc here? did it change upstream?

Merged already.

Subrata, it's recommended that changes are not submitted within the first 24 hours they are under review. (Technically the Makefile change did not meet that guideline.)

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Thu, 30 May 2019 16:45:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

31 May 31 May

11:54 a.m.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Patch Set 8:

...

Patch Set 8:

...
Patch Set 8:

This is weird. Why am I not seeing the changed amd/pi/Makefile.inc here? did it change upstream?

Merged already.

Subrata, it's recommended that changes are not submitted within the first 24 hours they are under review. (Technically the Makefile change did not meet that guideline.)

i ack my mistake and will make sure not happening in future. Hope we are good with merged CL.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Fri, 31 May 2019 09:54:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

ron minnich (Code Review)

12 Jun 12 Jun

7:29 a.m.

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable ......................................................................

Patch Set 9:

(1 comment)

"enabled"

https://review.coreboot.org/#/c/32751/9/src/include/rules.h File src/include/rules.h:

https://review.coreboot.org/#/c/32751/9/src/include/rules.h@261 PS9, Line 261: /* ENV_PAYLOAD_LOADER is set to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable */ enabled

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 9 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Wed, 12 Jun 2019 05:29:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

7:59 a.m.

New subject: Change in ...coreboot[master]: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

Hello Aaron Durbin, ron minnich, Furquan Shaikh, build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32751

to look at the new patch set (#10).

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled ......................................................................

Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/rules.h 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/32751/10

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 10 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

7:59 a.m.

New subject: Change in ...coreboot[master]: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

Hello Aaron Durbin, ron minnich, Furquan Shaikh, build bot (Jenkins), Furquan Shaikh, Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32751

to look at the new patch set (#11).

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled ......................................................................

Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Signed-off-by: Subrata Banik subrata.banik@intel.com --- M src/include/rules.h 1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/32751/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-MessageType: newpatchset

Subrata Banik (Code Review)

8 a.m.

New subject: Change in ...coreboot[master]: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled ......................................................................

Patch Set 11:

(1 comment)

https://review.coreboot.org/#/c/32751/9/src/include/rules.h File src/include/rules.h:

https://review.coreboot.org/#/c/32751/9/src/include/rules.h@261 PS9, Line 261: /* ENV_PAYLOAD_LOADER is set to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enable */

...

enabled

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Wed, 12 Jun 2019 06:00:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ron minnich rminnich@gmail.com Gerrit-MessageType: comment

ron minnich (Code Review)

8:22 a.m.

New subject: Change in ...coreboot[master]: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled ......................................................................

Patch Set 11: Code-Review+2

seems fine now. I can't wait to use it :-)

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Wed, 12 Jun 2019 06:22:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Subrata Banik (Code Review)

8:34 a.m.

New subject: Change in ...coreboot[master]: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled ......................................................................

Patch Set 11:

...

Patch Set 11: Code-Review+2

seems fine now. I can't wait to use it :-)

yes, i guess we are making some progress now in order to build coreboot without ramstage (thanks to add reviewers specifically Aaron and Julius)

now we need to add basic functionality into postcar to boot with full feature. Now here is 2 challenge

1. Dynamic generation of ASL code as we are not executing BS machine. I'm planning to create a smaller devicetree.cb with only required devices entry for dynamic ASL creation in postcar

2. Dynamic PCI BAR allocation based on free main memory to boot from boot media as depthcharge will expect to have BAR assigned. In absence of BS machine, dynamic BAR allocation will be key. hence a limited devicetree.cb in postcar to allocated #1 and #2 might solve these problem.

Like to hear more thoughts. remaining i have good visibility about how much code needs to put into postcar apart from #1 and #2 hack right now i'm having in code.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 11 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Comment-Date: Wed, 12 Jun 2019 06:34:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Subrata Banik (Code Review)

13 Jun 13 Jun

6:40 a.m.

New subject: Change in ...coreboot[master]: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32751 )

Change subject: Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled ......................................................................

Set ENV_PAYLOAD_LOADER to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled

Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Signed-off-by: Subrata Banik subrata.banik@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32751 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: ron minnich rminnich@gmail.com --- M src/include/rules.h 1 file changed, 5 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified ron minnich: Looks good to me, approved

diff --git a/src/include/rules.h b/src/include/rules.h index ce968f0..fcb827d 100644 --- a/src/include/rules.h +++ b/src/include/rules.h @@ -257,9 +257,14 @@

#endif

+#if CONFIG(RAMPAYLOAD) +/* ENV_PAYLOAD_LOADER is set to ENV_POSTCAR when CONFIG_RAMPAYLOAD is enabled */ +#define ENV_PAYLOAD_LOADER ENV_POSTCAR +#else /* ENV_PAYLOAD_LOADER is set when you are in a stage that loads the payload. * For now, that is the ramstage. */ #define ENV_PAYLOAD_LOADER ENV_RAMSTAGE +#endif

/** * For pre-DRAM stages and post-CAR always build with simple device model, ie.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32751 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I416c74ea83ee68370bbeb53834054bcb18e631e1 Gerrit-Change-Number: 32751 Gerrit-PatchSet: 13 Gerrit-Owner: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: ron minnich rminnich@gmail.com Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1982

days inactive

2015

days old

coreboot-gerrit@coreboot.org

19 comments

3 participants

tags (0)

participants (3)

Kyösti Mälkki (Code Review)
ron minnich (Code Review)
Subrata Banik (Code Review)