Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33417 )
Change subject: soc/intel: Add function to set DPR
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/33417/7/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/ramstage.c:
https://review.coreboot.org/c/coreboot/+/33417/7/src/soc/intel/fsp_broadwell...
PS7, Line 31: #include <soc/broadwell_de.h>
I would choose a sligthly incorrectly located header file, over two copies. […]
IMHO, If possible, I would suggest addressing the conflicts between fsp_broadwell_de and <intelblocks/systemagent.h>.
Considering the function name is "sa_set_dpr", and the "sa_" prefix usually stands for "system agent", I would much prefer it to be in <intelblocks/systemagent.h>
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33417
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43d2b50a7a6bb41146be99e645cd2ac6a6c9f703
Gerrit-Change-Number: 33417
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Roy Wen
rgzwen@arista.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Aug 2019 15:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-MessageType: comment