Attention is currently required from: Shelley Chen, Ravi kumar. Sudheer Amrabadi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57449 )
Change subject: Herobrine: sc7280: Add support for audio ......................................................................
Patch Set 28:
(4 comments)
Patchset:
PS28: Made changes as per comments
File src/mainboard/google/herobrine/board.h:
https://review.coreboot.org/c/coreboot/+/57449/comment/48e56c2f_812c9d10 PS20, Line 33:
one more tab
Ack
File src/mainboard/google/herobrine/chromeos.c:
https://review.coreboot.org/c/coreboot/+/57449/comment/a446eb23_9b9dbd96 PS20, Line 19: gpio_input_irq(GPIO_H1_AP_INT, IRQ_TYPE_RISING_EDGE, GPIO_PULL_UP);
TPM configuration should be in a separate CL
Ack
https://review.coreboot.org/c/coreboot/+/57449/comment/0924795a_5cc0cecc PS20, Line 32: {GPIO_H1_AP_INT.addr, ACTIVE_HIGH, gpio_get(GPIO_H1_AP_INT),
Same comment as above.
Ack
-
Sudheer Amrabadi (Code Review)