Attention is currently required from: Xi Chen, Nico Huber, Martin Roth, Paul Menzel, Julius Werner, Angel Pons, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50294 )
Change subject: vendor: mediatek: Add mediatek mt8192 dram initialization code
......................................................................
Patch Set 18:
(7 comments)
Patchset:
PS18:
Much better now, can you rebase this to the head so we can let buildbot verify and merge?
File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/50294/comment/9ee7c9fb_e125faea
PS15, Line 617: MT8192
Currently, only mt8192.
Ack
https://review.coreboot.org/c/coreboot/+/50294/comment/077ba5fd_cf929726
PS15, Line 618: Xi Chen xixi.chen@mediatek.com
Currently, mainly on DRAM, in MT8192 section now.
Ack
File MAINTAINERS:
https://review.coreboot.org/c/coreboot/+/50294/comment/866469e6_d651f21e
PS18, Line 620: k/
If the section is "MT8192" then you should have this as
mediatek/mt8192/
https://review.coreboot.org/c/coreboot/+/50294/comment/aaed6c93_742c5e69
PS18, Line 621: mt8192
mt8192/
(you need the trailing slash /)
File src/vendorcode/mediatek/Kconfig:
https://review.coreboot.org/c/coreboot/+/50294/comment/db0740c6_56791ca7
PS16, Line 1: SOC_MEDIATEK_MT8192
move the file to soc/mediatek/common.
Ack
File src/vendorcode/mediatek/mt8192/dramc/ANA_init_config.c:
https://review.coreboot.org/c/coreboot/+/50294/comment/d1b141dc_de5fe197
PS16, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
use GPL-2.0.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50294
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3853204578069c6abf52689ea6f5d88841414bd4
Gerrit-Change-Number: 50294
Gerrit-PatchSet: 18
Gerrit-Owner: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Cindy Ching
cindy.ching@mediatek.corp-partner.google.com
Gerrit-CC: Joel Kitching
kitching@google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
reinauer@chromium.org
Gerrit-CC: Werner Zeh
werner.zeh@siemens.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.corp-partner.google.com
Gerrit-Attention: Xi Chen
xixi.chen@mediatek.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Wed, 03 Mar 2021 08:00:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Xi Chen
xixi.chen@mediatek.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment