Attention is currently required from: Christian Walter, Eric Lai, Michael Niewöhner, Patrick Rudolph, Tarun Tuli, Yuchen He.
Hello Christian Walter, Eric Lai, Felix Singer, Michael Niewöhner, Patrick Rudolph, Tarun Tuli, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/75960?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed: Code-Review+2 by Eric Lai, Verified+1 by build bot (Jenkins)
Change subject: mb/{cfl,cml,whl}: Use true/false macros for s0ix_enable dt option ......................................................................
mb/{cfl,cml,whl}: Use true/false macros for s0ix_enable dt option
The true/false macros give the reader a better understanding about how the option should be used. Thus, replace 0/1 with false/true.
While on it, remove the quotes from the option name and from the value.
Coffeelake, Cometlake and Whiskeylake mainboards which use that option were changed by the following command ran from the top level directory.
dt_line="chip soc/intel/cannonlake" && \ option="s0ix_enable" && \ grep -r "${dt_line}" src/mainboard | \ cut -d ':' -f 1 | \ xargs sed -i'' -e "s/"${option}".*=.*"1"/${option} = true/g" -e "s/"${option}".*=.*"0"/${option} = false/g"
Change-Id: Ibfd1b1dc7d3a210e30d7007876f5aa8a8a0d4d34 Signed-off-by: Yuchen He yuchenhe126@gmail.com --- M src/mainboard/clevo/cml-u/variants/l140cu/devicetree.cb M src/mainboard/google/drallion/variants/drallion/devicetree.cb M src/mainboard/google/hatch/variants/baseboard/devicetree.cb M src/mainboard/google/puff/variants/baseboard/devicetree.cb M src/mainboard/google/sarien/variants/arcada/devicetree.cb M src/mainboard/google/sarien/variants/sarien/devicetree.cb M src/mainboard/intel/coffeelake_rvp/variants/baseboard/devicetree.cb M src/mainboard/intel/coffeelake_rvp/variants/cfl_u/overridetree.cb M src/mainboard/prodrive/hermes/devicetree.cb 9 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/75960/5