Attention is currently required from: Evan Green, Paul Menzel, Aseda Aboagye, Tyler Wang, Karthik Ramasubramanian.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60185 )
Change subject: mb/google/dedede/var/magolor: Add stylus pen function
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/dedede/variants/magolor/gpio.c:
https://review.coreboot.org/c/coreboot/+/60185/comment/b561fcb3_165a79af
PS1, Line 7: ramstage*/
Missing space.
Fixed in patchset2.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62489bb289b18f9aa0823005224eda3ef5218e03
Gerrit-Change-Number: 60185
Gerrit-PatchSet: 2
Gerrit-Owner: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Ren Kuo
ren.kuo@quanta.corp-partner.google.com
Gerrit-Reviewer: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Tyler Wang
tyler.wang@quanta.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 20 Dec 2021 02:43:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment