Change in coreboot[master]: mb/google/dedede/var/drawcia: Probe and enable DPTF configuration

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47010 )

Change subject: mb/google/dedede/var/drawcia: Probe and enable DPTF configuration
......................................................................


Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/drawcia/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/47010/5/src/mainboard/google/dedede... 
PS5, Line 139: # Default DPTF Policy for all drawcia boards if not overridden
             : 				register "options.tsr[0].desc" = ""Memory""
             : 				register "options.tsr[1].desc" = ""Ambient""
             : 				register "options.tsr[2].desc" = ""Charger""
             : 				register "options.tsr[3].desc" = ""5V regulator""
> Tim, I did not get your comment, please elaborate.  […]
> In short, the answer is no, right now you can't just define the sensor description entries only once, unless they come from some override. You could add something like this in the baseboard devicetree:
chip drivers/intel/dptf
        registers "options.tsr[0].desc" = ""Memory""
        ...
        device generic 0 off end
        registers "options.tsr[0].desc" = ""Memory""
        ...
        device generic 1 off end

and then any variants will automatically pick up those entries



-- 
To view, visit https://review.coreboot.org/c/coreboot/+/47010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibf166a2e36fa5775e2dea7c1adcae843cc143d32
Gerrit-Change-Number: 47010
Gerrit-PatchSet: 5
Gerrit-Owner: Karthik Ramasubramanian <[e-mail]>
Gerrit-Reviewer: Evan Green <[e-mail]>
Gerrit-Reviewer: Furquan Shaikh <[e-mail]>
Gerrit-Reviewer: Sumeet R Pawnikar <[e-mail]>
Gerrit-Reviewer: Tim Wawrzynczak <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Mon, 09 Nov 2020 22:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <[e-mail]>
Comment-In-Reply-To: Sumeet R Pawnikar <[e-mail]>
Comment-In-Reply-To: Karthik Ramasubramanian <[e-mail]>
Gerrit-MessageType: comment