Change in coreboot[master]: commonlib/fsp_relocate: Fix typos

List overview All Threads
Download

newer

older

Change in coreboot[master]: [WIP]...

Change in coreboot[master]:...

HAOUAS Elyes (Code Review)

18 Dec 2019 18 Dec '19

1:22 p.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37810 )

Change subject: commonlib/fsp_relocate: Fix typos ......................................................................

commonlib/fsp_relocate: Fix typos

Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/commonlib/fsp_relocate.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37810/1

diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c index 85deda247..7d66533 100644 --- a/src/commonlib/fsp_relocate.c +++ b/src/commonlib/fsp_relocate.c @@ -136,8 +136,8 @@ /* * A TE image is created by converting a PE file. Because of this * the offsets within the headers are off. In order to calculate - * the correct releative offets one needs to subtract fixup_offset - * from the encoded offets. Similarly, the linked address of the + * the correct relative offsets one needs to subtract fixup_offset + * from the encoded offsets. Similarly, the linked address of the * program is found by adding the fixup_offset to the ImageBase. */ fixup_offset = read_le16(&teih->StrippedSize);

Attachments:

attachment.htm (text/html — 2.7 KB)

Show replies by date

Paul Menzel (Code Review)

18 Dec 18 Dec

1:45 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37810 )

Change subject: commonlib/fsp_relocate: Fix typos ......................................................................

Patch Set 1: Code-Review+1

You should use a dedicated branch for this.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Gerrit-Change-Number: 37810 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 18 Dec 2019 12:45:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Frans Hendriks (Code Review)

2:25 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37810 )

Change subject: commonlib/fsp_relocate: Fix typos ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37810/1/src/commonlib/fsp_relocate.... File src/commonlib/fsp_relocate.c:

https://review.coreboot.org/c/coreboot/+/37810/1/src/commonlib/fsp_relocate.... PS1, Line 140: * from the encoded offsets. Similarly, the linked address of the Also removing additional space?

-- To view, visit https://review.coreboot.org/c/coreboot/+/37810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Gerrit-Change-Number: 37810 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-Comment-Date: Wed, 18 Dec 2019 13:25:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

3:29 p.m.

Hello Paul Menzel, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/37810

to look at the new patch set (#2).

Change subject: commonlib/fsp_relocate: Fix typos ......................................................................

commonlib/fsp_relocate: Fix typos

Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/commonlib/fsp_relocate.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/37810/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Gerrit-Change-Number: 37810 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

3:30 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37810 )

Change subject: commonlib/fsp_relocate: Fix typos ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/37810/1/src/commonlib/fsp_relocate.... File src/commonlib/fsp_relocate.c:

https://review.coreboot.org/c/coreboot/+/37810/1/src/commonlib/fsp_relocate.... PS1, Line 140: * from the encoded offsets. Similarly, the linked address of the

...

Also removing additional space?

Done. Thank you

-- To view, visit https://review.coreboot.org/c/coreboot/+/37810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Gerrit-Change-Number: 37810 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Frans Hendriks fhendriks@eltan.com Gerrit-Comment-Date: Wed, 18 Dec 2019 14:30:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Frans Hendriks fhendriks@eltan.com Gerrit-MessageType: comment

Frans Hendriks (Code Review)

3:34 p.m.

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37810 )

Change subject: commonlib/fsp_relocate: Fix typos ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/37810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Gerrit-Change-Number: 37810 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 18 Dec 2019 14:34:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

6:15 p.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37810 )

Change subject: commonlib/fsp_relocate: Fix typos ......................................................................

Patch Set 2:

...

Patch Set 1: Code-Review+1

You should use a dedicated branch for this.

Sorry, I'm not sure to understand what you mean.

-- To view, visit https://review.coreboot.org/c/coreboot/+/37810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Gerrit-Change-Number: 37810 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 18 Dec 2019 17:15:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

19 Dec 19 Dec

6:50 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37810 )

Change subject: commonlib/fsp_relocate: Fix typos ......................................................................

commonlib/fsp_relocate: Fix typos

Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37810 Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/commonlib/fsp_relocate.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved

diff --git a/src/commonlib/fsp_relocate.c b/src/commonlib/fsp_relocate.c index 85deda247..a8b45fa 100644 --- a/src/commonlib/fsp_relocate.c +++ b/src/commonlib/fsp_relocate.c @@ -136,8 +136,8 @@ /* * A TE image is created by converting a PE file. Because of this * the offsets within the headers are off. In order to calculate - * the correct releative offets one needs to subtract fixup_offset - * from the encoded offets. Similarly, the linked address of the + * the correct relative offsets one needs to subtract fixup_offset + * from the encoded offsets. Similarly, the linked address of the * program is found by adding the fixup_offset to the ImageBase. */ fixup_offset = read_le16(&teih->StrippedSize);

-- To view, visit https://review.coreboot.org/c/coreboot/+/37810 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9426b88c0936c68d02554b580cc312902b8e5e13 Gerrit-Change-Number: 37810 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Frans Hendriks fhendriks@eltan.com Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1600

days inactive

1601

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

Frans Hendriks (Code Review)
HAOUAS Elyes (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)