Attention is currently required from: Jan Philipp Groß, Máté Kukri.
Nicholas Chin has posted comments on this change by Jan Philipp Groß. ( https://review.coreboot.org/c/coreboot/+/82760?usp=email )
Change subject: mb/asrock: Add Z97E-ITX/ac (Haswell/Broadwell) ......................................................................
Patch Set 14:
(2 comments)
File src/mainboard/asrock/z97e-itx_ac/Kconfig:
https://review.coreboot.org/c/coreboot/+/82760/comment/45d50556_37c4ca84?usp... : PS14, Line 1: if BOARD_ASROCK_Z97E_ITX_AC Add SPDX header ```suggestion ## SPDX-License-Identifier: GPL-2.0-or-later if BOARD_ASROCK_Z97E_ITX_AC ```
File src/mainboard/asrock/z97e-itx_ac/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/82760/comment/1c53fdfa_96e0ccad?usp... : PS14, Line 14: 0x411111f0 ```suggestion AZALIA_PIN_CFG(0, 0x17, AZALIA_PIN_CFG_NC(0)), ``` This macro means the same thing as this raw hex value. See commit ca9f94854176 (mb/**/hda_verb: Use `AZALIA_PIN_CFG_NC(0)`) for reference.