Attention is currently required from: Kapil Porwal, Paul Menzel, Subrata Banik, Tarun Tuli.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75579?usp=email )
Change subject: mb/google/rex/variants/ovis: Add display configuration ......................................................................
Patch Set 9:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75579/comment/d09f250b_efc929bd : PS1, Line 7: configurarion
configuration
Done
https://review.coreboot.org/c/coreboot/+/75579/comment/65fbd49e_28f2cdee : PS1, Line 8:
Please elaborate.
Done
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75579/comment/3d431b2c_45d4f725 : PS1, Line 22: DDI_ENABLE_HPD
please make sure u have taken care of the GPIO programming as well.
I think all GPIOs are configured correctly now - or at least they are matching the mapping document, so everything should be fine.
File src/mainboard/google/rex/variants/ovis/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/75579/comment/7bbfbfa9_cc24e151 : PS5, Line 184: device ref ipu on end
can we submit a separate CL for this ?
I removed it for now. I will prepare appropriate patch when it's needed.