Attention is currently required from: Angel Pons, Christian Walter, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Shuo Liu, Tim Chu.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85316?usp=email )
Change subject: soc/intel/xeon_sp: Add PCU PCI drivers
......................................................................
Patch Set 10:
(3 comments)
File src/soc/intel/xeon_sp/pcu0.c:
https://review.coreboot.org/c/coreboot/+/85316/comment/f1cd15fe_b4876e36?usp... :
PS9, Line 31: .init = pcu0_init,
Is an empty init needed?
Done
File src/soc/intel/xeon_sp/pcu3.c:
https://review.coreboot.org/c/coreboot/+/85316/comment/17dc04f2_cce85788?usp... :
PS9, Line 27: .init = pcu3_init,
Same
Done
File src/soc/intel/xeon_sp/pcu6.c:
https://review.coreboot.org/c/coreboot/+/85316/comment/5e7c3b3a_bfa52de8?usp... :
PS9, Line 27: .init = pcu6_init,
Same
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85316?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4a58b80a1c9fd766946b17c11c629a9df79c573
Gerrit-Change-Number: 85316
Gerrit-PatchSet: 10
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Shuo Liu
shuo.liu@intel.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 09 Dec 2024 14:31:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com