Attention is currently required from: Bora Guvendik, Jérémy Compostella, Kapil Porwal, Kyoung Il Kim, Pranava Y N, Subrata Banik.
Cliff Huang has posted comments on this change by Cliff Huang. ( https://review.coreboot.org/c/coreboot/+/85199?usp=email )
Change subject: soc/intel/pantherlake: Update Touch Controller UPD params ......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/pantherlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/85199/comment/2aa419a3_ec17bf7d?usp... : PS3, Line 563: if (is_devfn_enabled(PCI_DEVFN_THC0)) { : s_cfg->ThcAssignment[0] = THC_0; : s_cfg->ThcMode[0] = config->thc_mode[0]; : s_cfg->ThcWakeOnTouch[0] = config->thc_wake_on_touch[0]; : } else { : s_cfg->ThcAssignment[0] = THC_NONE; : } : if (is_devfn_enabled(PCI_DEVFN_THC1)) { : s_cfg->ThcAssignment[1] = THC_1; : s_cfg->ThcMode[1] = config->thc_mode[1]; : s_cfg->ThcWakeOnTouch[1] = config->thc_wake_on_touch[1]; : } else { : s_cfg->ThcAssignment[1] = THC_NONE; : } : }
Bubrata, THC0/1 are used independent to each other. ex in fatcat/ptlrvp: THC0 is for touchscreen and THC1 is for touchpad. Although, when THC1 is enabled, THC0 needs to be enabled as well, which is taken care in devicetree with probe via fw_config. This is due to THC0 is PCI function 0 device.