Attention is currently required from: Sergii Dmytruk.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68991?usp=email )
Change subject: security/tpm/: turn tis_{init,open} into tis_probe
......................................................................
Patch Set 6:
(1 comment)
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/68991/comment/8c86d807_aa1797a6 :
PS6, Line 32: die("TSS 2.0 wasn't initialized\n");
It boots fine after reverting this change. Thanks Sergii for the due diligence. […]
Can't we just return NULL? If TPM command could nto be processed that is not such a big deal to halt the platform. Instead the caller should handle eventual error path
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68991?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4ce35ada24e3959ea1a518c29d431b4ae123809
Gerrit-Change-Number: 68991
Gerrit-PatchSet: 6
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 03 Aug 2023 14:37:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-MessageType: comment