Attention is currently required from: Tarun Tuli, Subrata Banik, Kapil Porwal, Sridhar Siricilla.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71687 )
Change subject: soc/intel: Add Kconfigs to define scaling factor for cores
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/acpi/cpu_hybrid.c:
https://review.coreboot.org/c/coreboot/+/71687/comment/3641f0ec_64c3a740
PS1, Line 78: soc_get_scaling_factor
Do we even need this function now?
Agreed. Maybe add some _Static_assert() on the CONFIG_SOC_INTEL_PERF_CORE_SCAL_FACTOR as a way to make sure that those are properly defined and configured (non zero).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71687
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I55e4d815116ef40c5f33be64ab495e942bf35ee8
Gerrit-Change-Number: 71687
Gerrit-PatchSet: 1
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Thu, 05 Jan 2023 18:25:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Gerrit-MessageType: comment