Attention is currently required from: Jason Glenesk, Marshall Dawson, Patrick Rudolph, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49252 )
Change subject: ACPI: Add common FADT SMI entries
......................................................................
Patch Set 5:
(1 comment)
File src/southbridge/amd/agesa/hudson/fadt.c:
https://review.coreboot.org/c/coreboot/+/49252/comment/6a5687d0_e3ef0cff
PS5, Line 34: fadt->acpi_disable = ACPI_SMI_CMD_DISABLE;
Need to sync these with cpu/x86/smm.h. ACPI_SMI_CMD_ENABLE == APM_CNT_ELOG_GSMI currently.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49252
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I82d5a1423d08377759b58bfb7012d56198b00c9a
Gerrit-Change-Number: 49252
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sun, 24 Jan 2021 21:10:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment