Attention is currently required from: Nico Huber, Maxim Polyakov, Angel Pons, Werner Zeh, Andrey Petrov. Hello build bot (Jenkins), Nico Huber, Maxim Polyakov, Paul Menzel, Mario Scheithauer, Angel Pons, Andrey Petrov,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/62889
to look at the new patch set (#2).
Change subject: soc/intel/apollolake: Correct enum for PrimaryVideoAdaptor FSP parameter ......................................................................
soc/intel/apollolake: Correct enum for PrimaryVideoAdaptor FSP parameter
Commit 1a4496e79f21 (soc/{apl,glk}: Allow to select the primary graphics device) adds code to set the FSP parameter 'PrimaryVideoAdaptor' based on the enum description of the FspmUpd.h for Apollo Lake.
Unfortunately, the comment in the header file does not match the implementation in the FSP and hence setting PrimaryVideoAdaptor to 'GPU_PRIMARY_IGD' will be treated as if the selection was 'GPU_PRIMARY_PCI'. This in turn leads to Linux gfx driver issues for earlier driver implementations.
This commit corrects the enum values for the FSP parameter to match the implementation.
TEST=Boot into Linux on mc_apl1 and verify that graphics works.
Change-Id: Iedbc144fa809f6d4587f5223b235ee95579c48f7 Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/soc/intel/apollolake/romstage.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/62889/2