Attention is currently required from: Christian Walter, Maximilian Brune, Lean Sheng Tan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68224 )
Change subject: mb/prodrive/atlas: Print HSID
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/prodrive/atlas/gpio.c:
https://review.coreboot.org/c/coreboot/+/68224/comment/da851fe3_a13c2dae
PS1, Line 10: PAD_CFG_GPI(GPP_A8, NONE, RSMRST), /* HSID_0 */
I just saw they were already configured in early gpios... […]
Ah, probably because *a certain someone* told Sheng to do so 😄
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68224
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb7aac1204bc297d16797cac5b32b119d0a9204b
Gerrit-Change-Number: 68224
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Mon, 10 Oct 2022 09:04:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment