[S] Change in coreboot[main]: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186

[Yang Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Knox Chiou, Paul Menzel, Xinxiong Xu, Yidi Lin, Yu-Ping Wu.

Yang Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )

Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186
......................................................................

Patch Set 8:

(7 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/84342/comment/40ce9867_e535cfb5?usp... :
PS6, Line 9: default
> unprovisioned

Done

https://review.coreboot.org/c/coreboot/+/84342/comment/25a2cc2b_0d5c7ae2?usp... :
PS6, Line 9: SKUD
> SKU

Done

https://review.coreboot.org/c/coreboot/+/84342/comment/4728b7d4_5a3acc5a?usp... :
PS6, Line 10: load
> use

Done

https://review.coreboot.org/c/coreboot/+/84342/comment/28981f4d_a84df6dd?usp... :
PS6, Line 10: dts
> DTS

Done

https://review.coreboot.org/c/coreboot/+/84342/comment/3778678a_4f343c06?usp... :
PS6, Line 11: 0x7fffffff
> unprovisioned

Done

File src/mainboard/google/corsola/boardid.c:

https://review.coreboot.org/c/coreboot/+/84342/comment/fa2bb022_4727c066?usp... :
PS6, Line 131: BOARD_GOOGLE_SQUIRTLE
> > Although Squirlte has only one DTS, since 0x7FFFFEFF is not configured in config. […]

Done

https://review.coreboot.org/c/coreboot/+/84342/comment/8f9377e6_95a8a576?usp... :
PS6, Line 118: 	if (cached_sku_code == CROS_SKU_UNPROVISIONED ||
             : 	    cached_sku_code == CROS_SKU_UNKNOWN) {
             : 		printk(BIOS_WARNING, "SKU code from EC: 0x%x\n", cached_sku_code);
             : 
             : 		if (CONFIG(BOARD_GOOGLE_STARYU_COMMON)) {
             : 			if (get_cpu_id() == MTK_CPU_ID_MT8186T) {
             : 				/* Reserve last 4 bits to report PANEL_ID */
             : 				cached_sku_code = 0x7FFFFEF0UL | panel_id();
             : 			} else {
             : 				cached_sku_code = 0x7FFFFFF0UL | panel_id();
             : 			}
             : 		} else if (get_cpu_id() == MTK_CPU_ID_MT8186T &&
             : 			  !CONFIG(BOARD_GOOGLE_VOLTORB) &&
             : 			  !CONFIG(BOARD_GOOGLE_SQUIRTLE)) {
             : 			/*
             : 			* Distinguish MT8186T from MT8186 to select different device trees
             : 			* in the payload. Voltorb/Squirtle are exception here, because right now
             : 			* they use 0x7FFFFFFF in the DTS compatible string. We'll need to change
             : 			* that to 0x7FFFFEFF in kernel before the exception can be dropped.
             : 			*/
             : 			cached_sku_code = CROS_SKU_UNPROVISIONED_MT8186T;
             : 		}
             : 	}
> What about […]

Done