Attention is currently required from: Patrick Georgi. Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59980 )
Change subject: libpayload: Remove shell for loops in install Makefile target ......................................................................
Patch Set 1:
(5 comments)
File payloads/libpayload/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/59980/comment/f2fad27c_9e710823 PS1, Line 107: install -m 644 $(library-targets) $(DESTDIR)/libpayload/lib/; I think, it would be safer to change it to: install [OPTION]... -t DIRECTORY SOURCE...
https://review.coreboot.org/c/coreboot/+/59980/comment/85916664_f13d7f33 PS1, Line 107: \ I think, you forgot to remove semicolon and backslash
https://review.coreboot.org/c/coreboot/+/59980/comment/04e5e104_c077e199 PS1, Line 114: find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} ; I think there should be '*.h' wildcard filter. Otherwise it might install unnecessary files.
https://review.coreboot.org/c/coreboot/+/59980/comment/63f88c4f_301be304 PS1, Line 115: cd $(coreboottop)/src/commonlib/bsd && find include -type d -exec install -m755 -d $(DESTDIR)/libpayload/{} ; Wont it create directories even if no files will be copied to them later?
https://review.coreboot.org/c/coreboot/+/59980/comment/a4d2c958_5822b9e2 PS1, Line 116: cd $(coreboottop)/src/commonlib/bsd && find include -type f -exec install -m644 {} $(DESTDIR)/libpayload/{} ; Same as above