Attention is currently required from: Lawrence Chang, Paul Menzel, Tongtong Pan, Weimin Wu.
Karthik Ramasubramanian has posted comments on this change by Tongtong Pan. ( https://review.coreboot.org/c/coreboot/+/83376?usp=email )
Change subject: mb/google/dedede: Create awasuki variant
......................................................................
Patch Set 13: -Code-Review
(1 comment)
Patchset:
PS13:
Can you please add the required data.vbt file in this CL? Without that, jenkins is reporting failure.
Ideally the automation script needs to be updated too, but we can update this CL for now before updating the automation script.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83376?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: If18afc92afdbdff5df3f5b034f4357feda6690b0
Gerrit-Change-Number: 83376
Gerrit-PatchSet: 13
Gerrit-Owner: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Lawrence Chang
lawrence.chang@intel.com
Gerrit-Reviewer: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Tongtong Pan
pantongtong@huaqin.corp-partner.google.com
Gerrit-Attention: Lawrence Chang
lawrence.chang@intel.com
Gerrit-Comment-Date: Wed, 17 Jul 2024 05:16:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes