Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Christian Walter. Eric Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63011 )
Change subject: drivers/i2c/tpm: Add workaround for Ti50 ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63011/comment/82e7f647_1c29559e PS4, Line 9: is not support board cfg
I do not understand the problem. Can you please elaborate. […]
this is what it's meaning. FW 0.15 and above is support board cfg, and vice versa.
https://review.coreboot.org/c/coreboot/+/63011/comment/807036f5_572c8f36 PS4, Line 11:
What is with the firmware versions inbetween?
all under 0.15...
File src/drivers/i2c/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/63011/comment/be0506e7_c8fe2646 PS4, Line 31: which
with?
Done
https://review.coreboot.org/c/coreboot/+/63011/comment/3cc7b46a_81360e1f PS4, Line 31: Board has a Ti50 I2C workaround which Ti50 FW under 0.15
Please elaborate.
Done
File src/drivers/i2c/tpm/cr50.c:
https://review.coreboot.org/c/coreboot/+/63011/comment/362ca1eb_86235506 PS4, Line 503: /* Ti50 FW version under 0.15 doesn't support board cfg
… anymore?
no more.
https://review.coreboot.org/c/coreboot/+/63011/comment/e2511e0c_d4205f71 PS4, Line 505: */
Belongs on the line above.
Done
-
Eric Lai (Code Review)