Attention is currently required from: Arthur Heymans, Benjamin Doron, Lance Zhao, Nico Huber.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75685?usp=email )
Change subject: acpi: Add SPCR table
......................................................................
Patch Set 5: Code-Review+2
(2 comments)
File src/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/75685/comment/0ebb4ab6_5d36cbf2 :
PS3, Line 1870: /* TODO: provide callback for IRQ on non standard ports*/
Would it be bad not to use an IRQ at all? […]
that should work for the earlycon, it looks like Linux doesn't use interrupts for the early console
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/75685/comment/097c0dbd_274ba245 :
PS5, Line 1336: #define RISCV_PLIC_COMPATIBLE_INTERRUPT (1 << 4)
minor nit: I won't hold up the patch, but would be nice to align the right sides
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75685?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I64e624c17a27b9215a8ba83bd6cbb2c0a7aa1dfc
Gerrit-Change-Number: 75685
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 18 Jun 2023 15:49:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment