Change in ...coreboot[master]: payload: Fix not to display `Fit support` on non-ARM platforms
Xiang Wang has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32056
Change subject: payload: Fix not to display `Fit support` on non-ARM platforms ......................................................................
payload: Fix not to display `Fit support` on non-ARM platforms
Change-Id: Ided1cc22173342fa751b84db5f08a5cf7408941d Signed-off-by: Xiang Wang wxjstz@126.com --- M payloads/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/32056/1
diff --git a/payloads/Kconfig b/payloads/Kconfig index c7a7ba6..d3f5927 100644 --- a/payloads/Kconfig +++ b/payloads/Kconfig @@ -100,6 +100,7 @@ bool "FIT support" default n default y if PAYLOAD_LINUX && (ARCH_ARM || ARCH_ARM64) + depends on ARCH_ARM || ARCH_ARM64 select FLATTENED_DEVICE_TREE help Select this option if your payload is of type FIT.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32056 )
Change subject: payload: Fix not to display `Fit support` on non-ARM platforms ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32056/2/payloads/Kconfig File payloads/Kconfig:
https://review.coreboot.org/#/c/32056/2/payloads/Kconfig@103 PS2, Line 103: depends on ARCH_ARM || ARCH_ARM64 it's only supported on ARM64
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32056 )
Change subject: payload: Fix not to display `Fit support` on non-ARM platforms ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32056/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32056/2//COMMIT_MSG@7 PS2, Line 7: payload: Fix not to display `Fit support` on non-ARM platforms Please use a statement by adding a verb in imperative mood.
Do not display `Fit support` on non-ARM platforms
Hello Patrick Rudolph, Angel Pons, Shawn C, Jonathan Neuschäfer, Stefan Reinauer, Philipp Deppenwiese, build bot (Jenkins), Philipp Hug, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32056
to look at the new patch set (#3).
Change subject: payload: Do not display `Fit support` on non-ARM platforms ......................................................................
payload: Do not display `Fit support` on non-ARM platforms
Change-Id: Ided1cc22173342fa751b84db5f08a5cf7408941d Signed-off-by: Xiang Wang wxjstz@126.com --- M payloads/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/32056/3
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32056 )
Change subject: payload: Do not display `Fit support` on non-ARM platforms ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/32056/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32056/2//COMMIT_MSG@7 PS2, Line 7: payload: Fix not to display `Fit support` on non-ARM platforms
Please use a statement by adding a verb in imperative mood. […]
Done
https://review.coreboot.org/#/c/32056/2/payloads/Kconfig File payloads/Kconfig:
https://review.coreboot.org/#/c/32056/2/payloads/Kconfig@103 PS2, Line 103: depends on ARCH_ARM || ARCH_ARM64
it's only supported on ARM64
Done
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32056 )
Change subject: payload: Do not display `Fit support` on non-ARM platforms ......................................................................
Patch Set 3: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32056 )
Change subject: payload: Do not display `Fit support` on non-ARM platforms ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/32056/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32056/3//COMMIT_MSG@7 PS3, Line 7: payload: Do not display `Fit support` on non-ARM platforms *non-ARM64* after the amendment.
Or: Only display `Fit support` on ARM64 platforms
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32056 )
Change subject: payload: Do not display `Fit support` on non-ARM platforms ......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/32056/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32056/3//COMMIT_MSG@7 PS3, Line 7: payload: Do not display `Fit support` on non-ARM platforms
*non-ARM64* after the amendment. […]
I would rather see the latter, since it does not use a double negative.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32056 )
Change subject: payload: Do not display `Fit support` on non-ARM platforms ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32056/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32056/3//COMMIT_MSG@7 PS3, Line 7: Fit nit: FIT in all-caps (abbreviation for Flattened Image Tree)
Hello Patrick Rudolph, Julius Werner, Angel Pons, Shawn C, Stefan Reinauer, Paul Menzel, Jonathan Neuschäfer, Philipp Deppenwiese, build bot (Jenkins), Philipp Hug, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32056
to look at the new patch set (#4).
Change subject: payload: Only display `Fit support` on ARM64 platforms ......................................................................
payload: Only display `Fit support` on ARM64 platforms
Change-Id: Ided1cc22173342fa751b84db5f08a5cf7408941d Signed-off-by: Xiang Wang wxjstz@126.com --- M payloads/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/32056/4
Hello Patrick Rudolph, Julius Werner, Angel Pons, Shawn C, Stefan Reinauer, Paul Menzel, Jonathan Neuschäfer, Philipp Deppenwiese, build bot (Jenkins), Philipp Hug, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32056
to look at the new patch set (#5).
Change subject: payload: Only display `FIT support` on ARM64 platforms ......................................................................
payload: Only display `FIT support` on ARM64 platforms
Change-Id: Ided1cc22173342fa751b84db5f08a5cf7408941d Signed-off-by: Xiang Wang wxjstz@126.com --- M payloads/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/32056/5
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32056 )
Change subject: payload: Only display `FIT support` on ARM64 platforms ......................................................................
payload: Only display `FIT support` on ARM64 platforms
Change-Id: Ided1cc22173342fa751b84db5f08a5cf7408941d Signed-off-by: Xiang Wang wxjstz@126.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32056 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Julius Werner jwerner@chromium.org --- M payloads/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Julius Werner: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/payloads/Kconfig b/payloads/Kconfig index c7a7ba6..d0f8a44 100644 --- a/payloads/Kconfig +++ b/payloads/Kconfig @@ -100,6 +100,7 @@ bool "FIT support" default n default y if PAYLOAD_LINUX && (ARCH_ARM || ARCH_ARM64) + depends on ARCH_ARM64 select FLATTENED_DEVICE_TREE help Select this option if your payload is of type FIT.
-
Angel Pons (Code Review) -
Julius Werner (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Xiang Wang (Code Review)