Attention is currently required from: Tim Wawrzynczak. Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/63008 )
Change subject: soc/intel/alderlake: Use coreboot native event handler for FSP-S ......................................................................
soc/intel/alderlake: Use coreboot native event handler for FSP-S
This patch assigns FSP handler event for FSP-S with coreboot ramstage debug handler when FSP_DEBUG_EVENT_HANDLER_IN_COREBOOT Kconfig is enabled.
BUG=b:225544587 TEST=Able to build and boot brya. Also, verified the FSP-S debug log is exactly same before and with this code change.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I665def977faaae45f6f834d75e8456859093ba49 --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/63008/1
diff --git a/src/soc/intel/alderlake/fsp_params.c b/src/soc/intel/alderlake/fsp_params.c index 4a27cb5..dfa496f 100644 --- a/src/soc/intel/alderlake/fsp_params.c +++ b/src/soc/intel/alderlake/fsp_params.c @@ -7,6 +7,7 @@ #include <device/pci.h> #include <device/pci_ids.h> #include <fsp/api.h> +#include <fsp/fsp_debug_event.h> #include <fsp/ppi/mp_service_ppi.h> #include <fsp/util.h> #include <option.h> @@ -509,6 +510,8 @@ static void fill_fsps_uart_params(FSP_S_CONFIG *s_cfg, const struct soc_intel_alderlake_config *config) { + if (CONFIG(FSP_DEBUG_EVENT_HANDLER_IN_COREBOOT)) + s_cfg->FspEventHandler = (UINT32)((FSP_EVENT_HANDLER *)fsp_debug_event_handler); /* PCH UART selection for FSP Debug */ s_cfg->SerialIoDebugUartNumber = CONFIG_UART_FOR_CONSOLE; ASSERT(ARRAY_SIZE(s_cfg->SerialIoUartAutoFlow) > CONFIG_UART_FOR_CONSOLE);