Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/83694?usp=email )
Change subject: acpi/acpigen_ps2_keybd: Fix total keymap size calculation ......................................................................
acpi/acpigen_ps2_keybd: Fix total keymap size calculation
This patch move keymap size calculation inside of has_alpha_num_punct_keys condition. When the condition is not met, it can prevent total keymaps size calculate incorrectly.
BUG=none TEST=emerge coreboot pass
Change-Id: I3dcf31d89924c1a8f2768e42065761b361e9ca41 Signed-off-by: Tyler Wang tyler.wang@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/83694 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com --- M src/acpi/acpigen_ps2_keybd.c 1 file changed, 2 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Subrata Banik: Looks good to me, approved
diff --git a/src/acpi/acpigen_ps2_keybd.c b/src/acpi/acpigen_ps2_keybd.c index 8691207..75e0b73 100644 --- a/src/acpi/acpigen_ps2_keybd.c +++ b/src/acpi/acpigen_ps2_keybd.c @@ -287,9 +287,10 @@ keymap = rest_of_keymaps[i]; acpi_dp_add_integer(dp_array, NULL, keymap); } + + total += ARRAY_SIZE(rest_of_keymaps); }
- total += ARRAY_SIZE(rest_of_keymaps); printk(BIOS_INFO, "PS2K: Passing %u keymaps to kernel\n", total);
acpi_dp_add_array(dp, dp_array);