Tim Crawford has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/76155?usp=email )
Change subject: mb/system76/{adl,tgl}: Add FMAP file ......................................................................
mb/system76/{adl,tgl}: Add FMAP file
Replace `CBFS_SIZE` with an FMAP file to declare regions and sizes. This will be used to lock BIOS region (except SMMSTORE) on boot.
Change-Id: I0f068f4d9b376f12b46faa5bb0c6a08e6cb744d8 Signed-off-by: Tim Crawford tcrawford@system76.com --- M src/mainboard/system76/adl/Kconfig A src/mainboard/system76/adl/board.fmd M src/mainboard/system76/tgl-h/Kconfig A src/mainboard/system76/tgl-h/board-gbe.fmd A src/mainboard/system76/tgl-h/board.fmd M src/mainboard/system76/tgl-u/Kconfig A src/mainboard/system76/tgl-u/board.fmd 7 files changed, 62 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/76155/1
diff --git a/src/mainboard/system76/adl/Kconfig b/src/mainboard/system76/adl/Kconfig index 83176d1..f13f81c 100644 --- a/src/mainboard/system76/adl/Kconfig +++ b/src/mainboard/system76/adl/Kconfig @@ -59,15 +59,15 @@ default "oryp9" if BOARD_SYSTEM76_ORYP9 default "oryp10" if BOARD_SYSTEM76_ORYP10
-config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y
config DIMM_SPD_SIZE default 512
+config FMDFILE + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd" + config ONBOARD_VGA_IS_PRIMARY default y
diff --git a/src/mainboard/system76/adl/board.fmd b/src/mainboard/system76/adl/board.fmd new file mode 100644 index 0000000..f50c357 --- /dev/null +++ b/src/mainboard/system76/adl/board.fmd @@ -0,0 +1,15 @@ +FLASH 32M { + SI_DESC 4K +#if CONFIG_MAINBOARD_USES_IFD_GBE_REGION + SI_GBE 8K +#endif + SI_ME 4824K + SI_BIOS@16M 16M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-h/Kconfig b/src/mainboard/system76/tgl-h/Kconfig index 7debee2..16b1da1 100644 --- a/src/mainboard/system76/tgl-h/Kconfig +++ b/src/mainboard/system76/tgl-h/Kconfig @@ -55,12 +55,13 @@ config OVERRIDE_DEVICETREE default "variants/$(CONFIG_VARIANT_DIR)/overridetree.cb"
-config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y
+config FMDFILE + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd" if !MAINBOARD_USES_IFD_GBE_REGION + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board-gbe.fmd" if MAINBOARD_USES_IFD_GBE_REGION + config ONBOARD_VGA_IS_PRIMARY default y
diff --git a/src/mainboard/system76/tgl-h/board-gbe.fmd b/src/mainboard/system76/tgl-h/board-gbe.fmd new file mode 100644 index 0000000..2bfb31c --- /dev/null +++ b/src/mainboard/system76/tgl-h/board-gbe.fmd @@ -0,0 +1,13 @@ +FLASH 16M { + SI_DESC 4K + SI_GBE 8K + SI_ME 5108K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-h/board.fmd b/src/mainboard/system76/tgl-h/board.fmd new file mode 100644 index 0000000..6f3a038 --- /dev/null +++ b/src/mainboard/system76/tgl-h/board.fmd @@ -0,0 +1,12 @@ +FLASH 16M { + SI_DESC 4K + SI_ME 5116K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +} diff --git a/src/mainboard/system76/tgl-u/Kconfig b/src/mainboard/system76/tgl-u/Kconfig index ea2419b..943a1c3 100644 --- a/src/mainboard/system76/tgl-u/Kconfig +++ b/src/mainboard/system76/tgl-u/Kconfig @@ -53,12 +53,12 @@ default "galp5" if BOARD_SYSTEM76_GALP5 default "lemp10" if BOARD_SYSTEM76_LEMP10
-config CBFS_SIZE - default 0xA00000 - config CONSOLE_POST default y
+config FMDFILE + default "src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd" + config POST_DEVICE default n
diff --git a/src/mainboard/system76/tgl-u/board.fmd b/src/mainboard/system76/tgl-u/board.fmd new file mode 100644 index 0000000..6f3a038 --- /dev/null +++ b/src/mainboard/system76/tgl-u/board.fmd @@ -0,0 +1,12 @@ +FLASH 16M { + SI_DESC 4K + SI_ME 5116K + SI_BIOS 11M { + RW_MRC_CACHE 64K + SMMSTORE(PRESERVE) 256K + WP_RO { + FMAP 4K + COREBOOT(CBFS) + } + } +}