Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36274 )
Change subject: arch/x86: Save the calling argument ......................................................................
Patch Set 9: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/36274/6/src/arch/x86/c_start.S File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/36274/6/src/arch/x86/c_start.S@68 PS6, Line 68: movl 4(%esp), %eax
Took me a while to figure out the need for offset 4 here. […]
Done
https://review.coreboot.org/c/coreboot/+/36274/9/src/arch/x86/c_start.S File src/arch/x86/c_start.S:
https://review.coreboot.org/c/coreboot/+/36274/9/src/arch/x86/c_start.S@111 PS9, Line 111: call main Out of scope, but isn't this 'lib/hardwaremain.c: void main(void)'? So leaving a gap between return address and arguments is wrong here but unnoticed, and we should remove the three 'push' instructions above?
-
Kyösti Mälkki (Code Review)