Attention is currently required from: Angel Pons, Nico Huber, Patrick Rudolph, Paul Menzel.
Anastasios Koutian has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email )
Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83269/comment/828e3eb1_7ed80029?usp... :
PS2, Line 9: Tested on ThinkPad T420 with the i7-3940XM.
Correction, […]
Done
File src/cpu/intel/model_206ax/chip.h:
https://review.coreboot.org/c/coreboot/+/83269/comment/3ea8d676_2bfe859e?usp... :
PS1, Line 46: int pl1; /* Long-term power limit*/
: int pl2; /* Short-term power limit*/
No too strong feelings about this, but I suggest to change it to milliwatts. […]
Done. Makes sense.
File src/cpu/intel/model_206ax/model_206ax_init.c:
https://review.coreboot.org/c/coreboot/+/83269/comment/e235e50e_4f5e4f42?usp... :
PS1, Line 99: dev->upstream->dev->upstream->children->chip_info;
Merged CB:83275. Please rebase.
Cool stuff, thanks!
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83269?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I064af25ec4805fae755eea52c4c9c6d4386c0aee
Gerrit-Change-Number: 83269
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasios Koutian
akoutian2@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 01 Jul 2024 16:57:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Anastasios Koutian
akoutian2@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com