Attention is currently required from: Julius Werner, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51620 )
Change subject: soc/mediatek: Use mrc_cache for asurada
......................................................................
Patch Set 4:
(1 comment)
File src/soc/mediatek/common/include/soc/dramc_param.h:
https://review.coreboot.org/c/coreboot/+/51620/comment/8e1cc9b5_33b00191
PS4, Line 60: u16 version; /* DRAMC_PARAM_HEADER_VERSION, update in the coreboot */
Note that you kind of have the version twice now... […]
one question: how does MRC driver make sure the blob is working at the correct version, if no version info was passed to blob?
we currently also rely on this version tag to make sure the image didn't incorrectly picked up wrong blobs.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51620
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief942048ce530433a57e8205d3a68ad56235b427
Gerrit-Change-Number: 51620
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 23 Mar 2021 01:51:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment