Attention is currently required from: Sean Rhodes, Tim Wawrzynczak, Patrick Rudolph.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59024 )
Change subject: soc/intel/tigerlake: Add config option for S3 ACPI
......................................................................
Patch Set 16:
(1 comment)
File src/soc/intel/tigerlake/acpi/tcss_pcierp.asl:
https://review.coreboot.org/c/coreboot/+/59024/comment/7df97941_4c3cce3c
PS16, Line 280: If ((TUID == 0) || (TUID == 1)) {
: Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT0 })
: } Else {
: Return (Package() { _SB.PCI0.D3C, _SB.PCI0.TBT1 })
:
nit: Use tabs for indentation
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59024
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb1cc3d6a03cb452ff38ae393a993e881d9b5ff4
Gerrit-Change-Number: 59024
Gerrit-PatchSet: 16
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 11 Nov 2021 14:25:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment