Attention is currently required from: Furquan Shaikh, Ricardo Quesada. Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56883 )
Change subject: elogtool: add "clear" command ......................................................................
Patch Set 3:
(3 comments)
File src/drivers/elog/elog.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/f1bf7dce_12d5df4f PS3, Line 825: indent to (
File util/cbfstool/elogtool.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/c2c2ff5e_2d933de5 PS2, Line 166: NULL
added. […]
hmm ... good point ... separate inputs and outputs may be a useful feature, especially for testing... but possibly in the future?
I think we can add it down the road
File util/cbfstool/elogtool.c:
https://review.coreboot.org/c/coreboot/+/56883/comment/1d01029f_465b0fe3 PS3, Line 200: { : buffer_delete(&buf); : return ret; : } you can drop the repeated code by using a goto
{ ... if (ret != 0) goto exit; ...
exit: buffer_delete(&buf); return ret; }