Attention is currently required from: Furquan Shaikh, Kevin Chang, Tim Wawrzynczak, Paul Menzel, Nick Vaccaro.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51200 )
Change subject: mb/google/volteer/variant/lindar: Disable SA GV for EVT build MB
......................................................................
Patch Set 4:
(3 comments)
File src/mainboard/google/volteer/romstage.c:
https://review.coreboot.org/c/coreboot/+/51200/comment/68853dfe_59993891
PS4, Line 25: memcfg_variant_init
I think you can put a default __weak memcfg_variant_init() in this file. For example:
void __weak memcfg_variant_init(FSPM_UPD *mupd)
{
}
after that, you can remove the __weak the *.h can *.c from the other files
File src/mainboard/google/volteer/variants/lindar/memory.c:
https://review.coreboot.org/c/coreboot/+/51200/comment/b3c705f7_710f1806
PS4, Line 67: __weak
remove this.
File src/soc/intel/tigerlake/include/soc/romstage.h:
https://review.coreboot.org/c/coreboot/+/51200/comment/92351c7d_291132a9
PS4, Line 10: void __weak memcfg_variant_init(FSPM_UPD *mupd);
I think you can put this to mainboard/google/volteer/variants/baseboard/include/baseboard/variants.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51200
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I51f4adcf0dd8dbf1cf39d8aec6e4303565551e5f
Gerrit-Change-Number: 51200
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Lauren Ting
lauren.ting@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Wed, 03 Mar 2021 14:35:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment