Attention is currently required from: Martin Roth, Angel Pons, Patrick Rudolph.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51187 )
Change subject: cpu/x86/smm: Drop the V1 smmloader
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51187/comment/95f731b4_4d7a2ea9
PS2, Line 7: cpu/x86/smm: Drop the V1 smmloader
To keep the diffstat meaningful, could you please rename `smm_module_loaderv2. […]
Done
File src/cpu/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/51187/comment/90205f51_3eb8fe5f
PS2, Line 124: config X86_SMM_LOADER_VERSION2
You missed the one instance of this symbol added in CB:44174
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51187
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I536a104428ae86e82977f2510b9e76715398b442
Gerrit-Change-Number: 51187
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Matt DeVillier
matt.devillier@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 16 Mar 2021 13:01:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment