Attention is currently required from: Julius Werner.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80008?usp=email )
Change subject: arch/arm: Reformat C files with clang-format v16 ......................................................................
Patch Set 1:
(2 comments)
File src/arch/arm/armv7/mmu.c:
https://review.coreboot.org/c/coreboot/+/80008/comment/23b86ba3_c62d91ca : PS1, Line 22:
How does it decide to do these comment indentations? Here it aligns to the comment in the previous l […]
I believe it's trying to align, but it combines the two comment lines and that breaks the alignment with length.
We have it set to align the comments.
https://review.coreboot.org/c/coreboot/+/80008/comment/a1821f11_bac0d129 : PS1, Line 93:
What is this? This looks like a bug? (It actually looks like it would align the closing brace, not t […]
Yeah, it probably is a bug. There seem to be several bugs in clang-format 16. I may try updating to clang-format 17 to see if any of these issue are fixed, but that then presents a problem with people running it on their own.
We chose clang-16 because that's what's included in the coreboot toolchain.