HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46165 )
Change subject: mb/gigabyte/ga-b75m-d3h: Convert to ASL 2.0 syntax ......................................................................
mb/gigabyte/ga-b75m-d3h: Convert to ASL 2.0 syntax
Change-Id: Ic9b7dfd786ff8e1512c8678590a1dad7c984bca8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/46165/1
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl b/src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl index 2544617..ae4ef30 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl +++ b/src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl @@ -21,10 +21,10 @@ Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
// Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) }
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46165
to look at the new patch set (#2).
Change subject: mb/gigabyte/ga-b75m-d3h: Convert to ASL 2.0 syntax ......................................................................
mb/gigabyte/ga-b75m-d3h: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' are identical.
Change-Id: Ic9b7dfd786ff8e1512c8678590a1dad7c984bca8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/46165/2
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46165 )
Change subject: mb/gigabyte/ga-b75m-d3h: Convert to ASL 2.0 syntax ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46165 )
Change subject: mb/gigabyte/ga-b75m-d3h: Convert to ASL 2.0 syntax ......................................................................
mb/gigabyte/ga-b75m-d3h: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' are identical.
Change-Id: Ic9b7dfd786ff8e1512c8678590a1dad7c984bca8 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46165 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl b/src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl index 2544617..ae4ef30 100644 --- a/src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl +++ b/src/mainboard/gigabyte/ga-b75m-d3h/acpi/thermal.asl @@ -21,10 +21,10 @@ Method (CTOK, 1) { // 10th of Degrees C - Multiply (Arg0, 10, Local0) + Local0 = Arg0 * 10
// Convert to Kelvin - Add (Local0, 2732, Local0) + Local0 += 2732
Return (Local0) }
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)