Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/73187 )
Change subject: soc/amd/picasso,stoneyridge/acpi: drop unneeded ARM_boot_arch assignment ......................................................................
soc/amd/picasso,stoneyridge/acpi: drop unneeded ARM_boot_arch assignment
The FADT data structure is zero-initialized in acpi_create_fadt which then calls the SoC-specific acpi_fill_fadt function, therefore it's not needed to assign 0 to the ARM_boot_arch FADT field in acpi_fill_fadt.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ica968db1228a2d63e83f2b6c4ea57c5f02bf1504 --- M src/soc/amd/picasso/acpi.c M src/soc/amd/stoneyridge/acpi.c 2 files changed, 14 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/73187/1
diff --git a/src/soc/amd/picasso/acpi.c b/src/soc/amd/picasso/acpi.c index 48b56f5..125aa0a 100644 --- a/src/soc/amd/picasso/acpi.c +++ b/src/soc/amd/picasso/acpi.c @@ -100,8 +100,6 @@ ACPI_FADT_REMOTE_POWER_ON; fadt->flags |= cfg->fadt_flags; /* additional board-specific flags */
- fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0; } diff --git a/src/soc/amd/stoneyridge/acpi.c b/src/soc/amd/stoneyridge/acpi.c index be9349d..40976af 100644 --- a/src/soc/amd/stoneyridge/acpi.c +++ b/src/soc/amd/stoneyridge/acpi.c @@ -91,8 +91,6 @@ ACPI_FADT_S4_RTC_VALID | ACPI_FADT_REMOTE_POWER_ON;
- fadt->ARM_boot_arch = 0; /* Must be zero if ACPI Revision <= 5.0 */ - fadt->x_firmware_ctl_l = 0; /* set to 0 if firmware_ctrl is used */ fadt->x_firmware_ctl_h = 0; }