[S] Change in coreboot[main]: mb/google/rauru: Implement SKU ID

[Yu-Ping Wu (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Knox Chiou.

Yu-Ping Wu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85666?usp=email )

Change subject: mb/google/rauru: Implement SKU ID
......................................................................

Patch Set 9:

(2 comments)

File src/mainboard/google/rauru/boardid.c:

https://review.coreboot.org/c/coreboot/+/85666/comment/e2916a5b_5cab2e9f?usp... :
PS9, Line 65:
>

If the definition starts getting that complicated, I'd suggest using `DEFINE_BITFIELD` API:

```
DEFINE_BITFIELD(STORAGE_TYPE, 11, 9);
DEFINE_BITFIELD(CPU_TYPE, 8, 8);
DEFINE_BITFIELD(PANEL_TYPE, 7, 0);

// sku_id()
cached_sku_code = CROS_SKU_UNPROVISIONED;
SET32_BITFIELDS(&cached_sku_code, STORAGE_TYPE, storage_id());
```

The code is self-explanatory.

It's a little bit weird to use MMIO functions, but I guess the extra `dmb` calls don't hurt.

https://review.coreboot.org/c/coreboot/+/85666/comment/a9243fe6_c3a6ed4a?usp... :
PS9, Line 77: 8
Shouldn't this be 9 if bit[11:9] is for storage id?