Hello Julius Werner, Paul Menzel, build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/32670
to review the following change.
Change subject: Revert "Makefile.inc: Enable -Wtype-limits" ......................................................................
Revert "Makefile.inc: Enable -Wtype-limits"
This reverts commit c4ab50cdde4bfd01ec7509012b105c88bcf4c953.
Reason for revert: vboot recently was changed so that -Wtype-limits fails, and that was just brought upstream. Since vboot internals are more likely to be used elsewhere while -Wtype-limits is less critical, revert this until vboot is resolved, then bring -Wtype-limits back again.
Change-Id: I9cce10462b9e57189513fa49e11fd27ebe35ba51 --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/32670/1
diff --git a/Makefile.inc b/Makefile.inc index 9860da1..a9aaaed 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -401,7 +401,7 @@ CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits +CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie ifeq ($(CONFIG_COMPILER_GCC),y)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32670 )
Change subject: Revert "Makefile.inc: Enable -Wtype-limits" ......................................................................
Patch Set 1: Code-Review+1
Commit message seems to have too long lines and is missing a Signed-Off line.
Hello Angel Pons, Julius Werner, Paul Menzel, build bot (Jenkins), Furquan Shaikh, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32670
to look at the new patch set (#2).
Change subject: Revert "Makefile.inc: Enable -Wtype-limits" ......................................................................
Revert "Makefile.inc: Enable -Wtype-limits"
This reverts commit c4ab50cdde4bfd01ec7509012b105c88bcf4c953.
Reason for revert: vboot recently was changed so that -Wtype-limits fails, and that was just brought upstream. Since vboot internals are more likely to be used elsewhere while -Wtype-limits is less critical, revert this until vboot is resolved, then bring -Wtype-limits back again.
Change-Id: I9cce10462b9e57189513fa49e11fd27ebe35ba51 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/32670/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32670 )
Change subject: Revert "Makefile.inc: Enable -Wtype-limits" ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32670 )
Change subject: Revert "Makefile.inc: Enable -Wtype-limits" ......................................................................
Revert "Makefile.inc: Enable -Wtype-limits"
This reverts commit c4ab50cdde4bfd01ec7509012b105c88bcf4c953.
Reason for revert: vboot recently was changed so that -Wtype-limits fails, and that was just brought upstream. Since vboot internals are more likely to be used elsewhere while -Wtype-limits is less critical, revert this until vboot is resolved, then bring -Wtype-limits back again.
Change-Id: I9cce10462b9e57189513fa49e11fd27ebe35ba51 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/32670 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile.inc 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Makefile.inc b/Makefile.inc index 9860da1..a9aaaed 100644 --- a/Makefile.inc +++ b/Makefile.inc @@ -401,7 +401,7 @@ CFLAGS_common += -pipe -g -nostdinc -std=gnu11 CFLAGS_common += -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes CFLAGS_common += -Wwrite-strings -Wredundant-decls -Wno-trigraphs -CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time -Wtype-limits +CFLAGS_common += -Wstrict-aliasing -Wshadow -Wdate-time CFLAGS_common += -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer CFLAGS_common += -ffunction-sections -fdata-sections -fno-pie ifeq ($(CONFIG_COMPILER_GCC),y)
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)