[XS] Change in coreboot[main]: soc/intel/pmclib.c: Make sure array_size is not 0 - coreboot-gerrit

23 Aug 2024


      Attention is currently required from: Angel Pons, Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/84042?usp=email )
Change subject: soc/intel/pmclib.c: Make sure array_size is not 0
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/common/block/pmc/pmclib.c:
https://review.coreboot.org/c/coreboot/+/84042/comment/248233b9_02b88c21?usp... :
PS7, Line 104: 	for (i = num_bits - 1; i >= 0; i--) {
I don't get it, it should never enter the loop body with `num_bits == 0`, right?
On first sight, this looks like a compiler bug? What did it complain about specifically?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84042?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ieee6e9bddc4e738eb560dd0e69dc3087ac9f5da6
Gerrit-Change-Number: 84042
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Fri, 23 Aug 2024 12:31:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No