Attention is currently required from: Nico Huber, Furquan Shaikh, Paul Menzel, Julius Werner, Arthur Heymans, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57627 )
Change subject: arch/x86,cpu/x86: Introduce new method for accessing cpu_info
......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57627/comment/8a5b92d4_645d9b50
PS6, Line 19: This means that when smm_do_relocation is executed, it is running in SMM
Ah, would be nice to have that in the commit message. To me it made the […]
COOP_MULTITASKING doesn't change SMM code. It's only compiled into romstage/ramstage right now. It's the fact that we run ramstage code in SMM that causes the problem.
Patchset:
PS6:
I agree that it should be avoided to have multiple implementations for that same functionality, but […]
I'll send a follow up to always use CPU_INFO_V2 for PARALLEL_MP.
PS6:
I'm going to merge this since it's been silent for a while now with no objections.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57627
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79dce9597cb784acb39a96897fb3c2f2973bfd98
Gerrit-Change-Number: 57627
Gerrit-PatchSet: 6
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 05 Oct 2021 22:10:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment