Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons.
wouter.eckhardt@prodrive-technologies.com has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56086 )
Change subject: [TESTME] mb/prodrive/hermes: Update HDA codec subvendor ID
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File src/mainboard/prodrive/hermes/variants/baseboard/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/56086/comment/63ebb011_f3824a93
PS1, Line 10: AZALIA_SUBVENDOR(0, 0x1d330067),
I think the lower two bytes need to be swapped so it matches our ID, i.e. 0x1d336700.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56086
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I72be8bde59d9eb0c1eff8c65dc734c6805732e09
Gerrit-Change-Number: 56086
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: wouter.eckhardt@prodrive-technologies.com
Gerrit-Attention: Justin van Son
justin.van.son@prodrive-technologies.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 05 Jul 2021 12:46:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment