HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46156 )
Change subject: mb/asus/a88xm-e: Convert to ASL 2.0 syntax ......................................................................
mb/asus/a88xm-e: Convert to ASL 2.0 syntax
Change-Id: I8887b869e9ed809f7861b810c2fb994fa2ee062e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/a88xm-e/acpi/sleep.asl 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/46156/1
diff --git a/src/mainboard/asus/a88xm-e/acpi/sleep.asl b/src/mainboard/asus/a88xm-e/acpi/sleep.asl index 8777337..46f37f3 100644 --- a/src/mainboard/asus/a88xm-e/acpi/sleep.asl +++ b/src/mainboard/asus/a88xm-e/acpi/sleep.asl @@ -22,10 +22,10 @@ Method(_PTS, 1) {
/* Clear wake status structure. */ - Store(0, Index(WKST,0)) - Store(0, Index(WKST,1)) + WKST [0] = 0 + WKST [1] = 0
- Store (0x07, UPWS) + UPWS = 0x07 } /* End Method(_PTS) */
/*
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/46156
to look at the new patch set (#2).
Change subject: mb/asus/a88xm-e: Convert to ASL 2.0 syntax ......................................................................
mb/asus/a88xm-e: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are identical.
Change-Id: I8887b869e9ed809f7861b810c2fb994fa2ee062e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/asus/a88xm-e/acpi/sleep.asl 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/46156/2
Attention is currently required from: HAOUAS Elyes. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46156 )
Change subject: mb/asus/a88xm-e: Convert to ASL 2.0 syntax ......................................................................
Patch Set 2: Code-Review+2
Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46156 )
Change subject: mb/asus/a88xm-e: Convert to ASL 2.0 syntax ......................................................................
mb/asus/a88xm-e: Convert to ASL 2.0 syntax
Generated 'build/dsdt.dsl' files are identical.
Change-Id: I8887b869e9ed809f7861b810c2fb994fa2ee062e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/46156 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/asus/a88xm-e/acpi/sleep.asl 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/asus/a88xm-e/acpi/sleep.asl b/src/mainboard/asus/a88xm-e/acpi/sleep.asl index 8777337..46f37f3 100644 --- a/src/mainboard/asus/a88xm-e/acpi/sleep.asl +++ b/src/mainboard/asus/a88xm-e/acpi/sleep.asl @@ -22,10 +22,10 @@ Method(_PTS, 1) {
/* Clear wake status structure. */ - Store(0, Index(WKST,0)) - Store(0, Index(WKST,1)) + WKST [0] = 0 + WKST [1] = 0
- Store (0x07, UPWS) + UPWS = 0x07 } /* End Method(_PTS) */
/*
-
HAOUAS Elyes (Code Review) -
Michael Niewöhner (Code Review)